FIX #44 - correctly set invalid labels to undefined #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulp-version-for-travis specify [email protected] in travis config
|
thanks for reporting this bug and contributing a fix! will have a look soon. |
|
hi @channeladam, when you have a moment, could you rebase this branch with master to bring in the fix for travis? full instructions here in case they are helpful 😄 #43 (comment) |
…ithub.com/channeladam/visjs-network into fix-short-circuit-draw-visible-in-labeljs
|
hooray, the tests pass. thanks for your patience @channeladam, and for contributing this fix. |
This was referenced Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #44