Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: 486 Change method to use deepStrictEqual. #509

Merged
merged 1 commit into from
Sep 6, 2018
Merged

bugfix: 486 Change method to use deepStrictEqual. #509

merged 1 commit into from
Sep 6, 2018

Conversation

mikelax
Copy link
Contributor

@mikelax mikelax commented Sep 5, 2018

Closes #486

Change _assertBody to use deepStrictEqual instead of deepEqual

@mikelax mikelax added this to the v3.2.0 milestone Sep 5, 2018
@mikelax mikelax self-assigned this Sep 5, 2018
@mikelax mikelax requested a review from rimiti September 5, 2018 14:29
@coveralls
Copy link

coveralls commented Sep 5, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 320

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.285%
Totals Coverage Status
Change from base Build 318: 0.0%
Covered Lines: 136
Relevant Lines: 140
💛 - Coveralls

rimiti
rimiti approved these changes Sep 5, 2018
View reviewed changes
Copy link
Contributor

@rimiti rimiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is ok. Good job!

@rimiti rimiti mentioned this pull request Sep 5, 2018
Merged
@rimiti
Copy link
Contributor

rimiti commented Sep 5, 2018

@mikelax A small refact related with this PR is available. 😉 #510

@mikelax mikelax modified the milestones: v3.2.0, v3.3.0 Sep 5, 2018
@mikelax mikelax merged commit 510a7ae into master Sep 6, 2018
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Nov 6, 2018
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 5, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rimiti rimiti rimiti approved these changes

Assignees

@mikelax mikelax

Labels
None yet
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mikelax @coveralls @rimiti