Disable setting default user-agent #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please fix the tests @apoorv-mishra? |
Revert "Disable setting default user-agent" This reverts commit 01841cc6fc2e5884b2259bf369d0ffba8d5618c1. Disable setting default user-agent Remove unused var
|
@niftylettuce Updated. |
|
I've released this as v5.1.0 to npm, it has a minor version bump because existing users may have issues with the user-agent being stripped in this version.
https://github.com/visionmedia/superagent/releases/tag/v5.1.0 |
|
IMHO, this would have been better as a breaking / major change. |
For instance this does break https://github.com/lambtron/get-stargazers-emails - FWIW |
lfdebrux
added a commit
to alphagov/govuk-prototype-kit
that referenced
this pull request
Dec 16, 2021
Previously we were relying on VERSION.txt for the name of the latest release, however this doesn't work in scenarios where we have changed the version number in preperation but have not yet made the release, as we found recently (see issue #1205). Instead we get the latest release version using the GitHub API [[1]]. Note that we have to drop the `v` at the beginning of the tag name, because for some reason GitHub doesn't include that in the archive file name. This commit uses the `superagent` library to do the request to avoid a lot of boilerplate; note that we have to set the user agent to something, because otherwise GitHub will forbid the request [[2]]. [1]: #1205 (comment) [2]: ladjs/superagent#1495 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1479