Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use shadow dom when available #284

Merged
merged 1 commit into from
Nov 18, 2015
Merged

use shadow dom when available #284

merged 1 commit into from
Nov 18, 2015

Conversation

MWalid
Copy link
Contributor

@MWalid MWalid commented Jun 28, 2015

tested with chrome, safari and firefox.

@MWalid
Copy link
Contributor Author

MWalid commented Jun 28, 2015

This fix will work with browsers which support shadow dom natively like google chrome and others that don't like safari ....

@StatelessCat
Copy link

This fix will be helpful, do you plan to integrate it soon?
Thanks.

@benoitv-code
Copy link

Tested locally with Polymer 1.2.3 and page.js 1.6.4:

  • Without this patch, page.js:
    • works well when shadow DOM is disabled.
    • doesn't work when shadow DOM is enabled.
  • With this patch, page.js:
    • works well when shadow DOM is disabled.
    • works well when shadow DOM is enabled.

Any plan to integrate it soon?

Thanks!

rstacruz added a commit that referenced this pull request Nov 18, 2015
use shadow dom when available
@rstacruz rstacruz merged commit 4895e37 into visionmedia:master Nov 18, 2015
@rstacruz
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants