Skip to content

Commit

Permalink
hotfix for babel-core
Browse files Browse the repository at this point in the history
  • Loading branch information
@thebigredgeek
thebigredgeek committed Dec 21, 2016
1 parent 5a1a36c commit a31178c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions node.js
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
module.exports = require('./src/node');

5 comments on commit a31178c

@nickpatrick
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@FezVrasta
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never, never, do it again. Please. 🙂

@thebigredgeek
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FezVrasta we didn't really do anything. The problem is that babel was importing a private file rather than requiring debug as it was intended to be required, via the main file

@xtuc
Copy link

@xtuc xtuc commented on a31178c Dec 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is there babel/babel#5029.

Babel's changelog:

Use debug/node instead of debug to avoid browserify using the browser version that references window.

I'm trying to figure out what was the issue with Browserify. Do you guys know?

@Qix-
Copy link
Member

@Qix- Qix- commented on a31178c Sep 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please never introduce technical debt like this again without properly documenting it. #603 (comment)

Contributing to severe headaches years later, as most technical debt tends to do.

Please sign in to comment.