Skip to content

Commit

Permalink
Fixed a typo (#356)
Browse files Browse the repository at this point in the history
  • Loading branch information
diedsmiling authored and thebigredgeek committed Dec 14, 2016
1 parent b82d4e6 commit 94d78b5
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions debug.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,12 @@ var prevTime;

function selectColor(namespace) {
var hash = 0, i;

for (i in namespace) {
hash = ((hash << 5) - hash) + namespace.charCodeAt(i);
hash |= 0; // Convert to 32bit integer
}

return exports.colors[Math.abs(hash) % exports.colors.length];
}

Expand Down Expand Up @@ -123,7 +123,7 @@ function createDebug(namespace) {
debug.namespace = namespace;
debug.enabled = exports.enabled(namespace);
debug.useColors = exports.useColors();
debug.color = selectColor(namespae);
debug.color = selectColor(namespace);

This comment has been minimized.

Copy link
@arjunpola

arjunpola Dec 14, 2016

Thank you. This caused so much pain!

This comment has been minimized.

Copy link
@yallups

yallups Dec 14, 2016

🙌 🙌 🙌 🙌 🙌 🙌

This comment has been minimized.

Copy link
@kid-wumeng

kid-wumeng Dec 14, 2016

good, it's let my website can't start...

This comment has been minimized.

Copy link
@diedsmiling

diedsmiling Dec 14, 2016

Author Contributor

^_^

This comment has been minimized.

Copy link
@Waize

Waize Dec 14, 2016

this is breaking our builds now ^^

This comment has been minimized.

Copy link
@AvailCat

AvailCat Dec 14, 2016

Ooops... I never think i will run into such issue....


// env-specific initialization logic for debug instances
if ('function' === typeof exports.init) {
Expand Down

7 comments on commit 94d78b5

@otarim
Copy link

@otarim otarim commented on 94d78b5 Dec 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exo me????

@amormysh
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diedsmiling aha.. i was wondering how come my react-native packager suddenly fails :)

@petekanev
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diedsmiling that got us for a moment there... careful when publishing :D

@thebigredgeek
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about this guys. It was late and I usually don't run sanity checks when releasing code changes made by core contribs. Adding test coverage and static analysis to make sure this doesn't happen in the future.

@martinamps
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

serves as a great reminder: pin your packages! ;)

@petekanev
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martinamps all good, unless you use a package that depends on this package :)

@gr2m
Copy link

@gr2m gr2m commented on 94d78b5 Dec 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the hugs @thebigredgeek happens to all of us :) Thanks for putting in effort to prevent this from happening again. I woke up to Greenkeeper telling me the whole story :) gr2m/selsa#14

Please sign in to comment.