Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpamAssassain - Header and body test - if you do not put a test name in the whole record is wiped when you savvve #957

Open
shoulders opened this issue Nov 9, 2024 · 1 comment

Comments

@shoulders
Copy link

SYSTEM INFORMATION
OS type and version Ubuntu Linux 22.04.5
Usermin version 2.102
Virtualmin version 7.20.2 Pro
Theme version 21.20.7
Apache version 2.4.52
Package updates 49 package updates are available

the issue

on the page Virtualmin --> Mail Options --> SpamAssassain Configuration-->Header and Body Tests if you make a rule and save it but have not out a test name in the whole rule will be wiped

image

after save

image

proposed solution

on each line put a javascript event to make sure if any date is entered on a line then the test name must not be empty. the empty Test Name field would also be highlighted with a red border to show the user's error.

@iliajie
Copy link
Collaborator

iliajie commented Nov 9, 2024

Hello,

Technically, we could use:

&ui_textbox("name_$i", $s->{'name'}, 20, undef, undef, 'required'),

…in edit_simple.cgi, but it won’t work straightforward because we don’t always need to fill all the rows. So yes, it would require a rework with some kind of JavaScript validation. As for the previous report—I don’t believe it’s worth the time and effort right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants