Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap Misused on About Page #169

Open
jaidevshriram opened this issue Mar 17, 2019 · 1 comment
Open

Bootstrap Misused on About Page #169

jaidevshriram opened this issue Mar 17, 2019 · 1 comment

Comments

@jaidevshriram
Copy link

1. NavBar Issues:

There is no button for the navbar on small devices. Something along the lines of <button class="navbar-toggler navbar-toggler-right" type="button" data-toggle="collapse" data-target="#navbarResponsive" aria-controls="navbarResponsive" aria-expanded="false" aria-label="Toggle navigation"> is missing.

There appears to be a redundant second navbar as well as seen here:

image

2. Row classes aren't enclosed by container / container-fluid:

Bootstrap documentation details that the grid system can only work inside a container.
image

3. Faulty Image Scaling:

Due to the lack of a boundary on the image, it scales to occupy a large portion of the page.

image

Fixes:

These should be pretty simple fixes. Just a few tweaks to the existing code should be required.

@jaidevshriram
Copy link
Author

The navbar issue along with #173 are prominent on Experiment-10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant