Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow FDO container test trigger not working due to Missing either 'issue-number' or 'comment-id' #8999

Closed
mcattamoredhat opened this issue Dec 3, 2024 · 3 comments

Comments

@mcattamoredhat
Copy link
Collaborator

Workflow FDO container test trigger not working due to Missing either 'issue-number' or 'comment-id'

We've tried to update to versions v4 and v7.0.5 of peter-evans/create-or-update-comment@v4 and peter-evans/[email protected] repectively, but the issue remains.

Latest failing workflow: https://github.com/virt-s1/rhel-edge/actions/runs/12103799105/job/33746404609#step:6:10

@mcattamoredhat
Copy link
Collaborator Author

This issue is still happening.

Latest failing workflow: https://github.com/virt-s1/rhel-edge/actions/runs/12579620667/job/35060104823

The output of this step https://github.com/virt-s1/rhel-edge/actions/runs/12579620667/job/35060104823#step:5:57 is empty and No local changes to save are detected. Then, the branch is not created, and the workflow fails.

Comparing to a previous successful workflow https://github.com/virt-s1/rhel-edge/actions/runs/11719276998/job/32642186654#step:5:55 output should be the following instead:

  ?? fdo-container.run
  Uncommitted changes found. Adding a commit.

What would happen if we remove fdo-container.run file at the end of the workflow? This way, the workflow will create the file every time it runs. Could this be a possible workaround? What do you think @yih-redhat ?

@mcattamoredhat
Copy link
Collaborator Author

I suspect this issue is being caused by the file fdo-container.run

The mentioned file is not supposed to exist on main branch (right now it exist). This PR #8853 was committed on November 11th.

Thus, the workaround should be straightforward and as simple as removing fdo-container.run from main branch. A PR will be created.

@mcattamoredhat
Copy link
Collaborator Author

Fixed by #9145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant