Fix bounds of singed integers for overflow checking #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dspil
approved these changes
Nov 15, 2024
gottschali
added a commit
to viperproject/gobra-book
that referenced
this pull request
Nov 18, 2024
jcp19
pushed a commit
to viperproject/gobra-book
that referenced
this pull request
Dec 13, 2024
* chore: add overflow section * chore: fixed abs overflow viperproject/gobra#795
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current bounds specified for singed integer types are off. This PR fixes that.
The added test is rejected in the current state of Gobra, even though the program should definitely pass.
Reported by @gottschali