Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox compatibility #54

Closed
yuchi328 opened this issue Oct 29, 2021 · 9 comments
Closed

Firefox compatibility #54

yuchi328 opened this issue Oct 29, 2021 · 9 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@yuchi328
Copy link

Describe the bug
Thanks for the new version release! I had an issue when using it on Firefox. It seems that the current version is not very compatible with Firefox, brush strokes are not displayed properly.

To Reproduce
Run on Firefox browser, and draw.

Desktop (please complete the following information):

  • OS: MacOS
  • Browser: Firefox
@jsalgado2510
Copy link

I am having the same issue on Firefox with Fedora Linux. This issue doesn't occur with Google Chrome.

@vinothpandian
Copy link
Owner

Looks like a performance issue due to rendering. I wanted to change the underlying data structure of CanvasPath to handle this in v7.

If anyone else figures out a simpler way of solving this, please make a PR

@vinothpandian vinothpandian added the good first issue Good for newcomers label Nov 9, 2021
@ivan-at-hypothetic
Copy link

Do you plan to work on this issue in the near future?

@vinothpandian
Copy link
Owner

@ivan-at-hypothetic Yes in the near future, but I didn't have much time to spend on it recently. However, if you have a fix, please send a PR.

@sebastian-comisario-osanasalud

Hi everyone!
Any news about this issue?

@vinothpandian vinothpandian self-assigned this Jan 16, 2023
@vinothpandian
Copy link
Owner

Fixed with 7.0.0.next.0 release

@zeke
Copy link

zeke commented Feb 28, 2023

Hey @vinothpandian. Unfortunately I think this bug still persists in the new version you mentioned.

Here's a repro video: https://www.loom.com/share/b804e56441d6494f96d24e83dd2634ed

@zeke
Copy link

zeke commented Mar 3, 2023

Here's how we're working around it: replicate/scribble-diffusion#31 (comment)

@vinothpandian
Copy link
Owner

Thanks @zeke! Seems like the eraser is the problem. I will add a stroke eraser option where users can delete strokes as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants