Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Test that I've selected valid combo of direction, origin and destination stop #105

Closed
jpaulickcz opened this issue Sep 13, 2024 · 4 comments

Comments

@jpaulickcz
Copy link

First of all, thank you for this. I've been using original gtfs integration for about two years and it was fine for the three lines I have available from my apartment; but I've now wanted to put public transport times to additional HA instances I have at different places (my parents house etc.), and this has made it so much easier!

Describe the solution you'd like
image

I think it would be a good idea to have some sort of "test validity" button at this step in adding schedule. At least for my city, every line shows multiple stops of the same name - sometimes up to four (one entry for bus stop, one for tram stop, times two for each direction - and this is shown even when I've specifically selected a bus line; but it sometimes does use the tram terminal... it's just a mess :D).

Since I know my city's GTFS formatting and naming conventions for the stops a little by know, it was fairly easy to navigate, but I've still chosen the wrong combo a few times which resulted in the "Start and/or End destination incorrect, possibly no transport 'today' or not in same direction, please check logs" error message and having to start over, instead of just switching one stop and trying again.

Thanks for considering this :)

@vingerha
Copy link
Owner

vingerha commented Sep 13, 2024

Thanks for the feedback
On the requirement, I believe you want to avoid re-re-re-re opening the same screens with route/stops/etc. until you have a combination that works, not?
Actually... this 'test' is part of the next step after this screen...when you press 'submit', hence you receive that message "...incorrect, possibly..."
There are some challenges and I am not very confident that this can be resolved easily.

  1. this is part of configflow functionality of HA, it works but it is limited as well. There is no option to add a button to trigger something else.
  2. when you are in that screen, it only has selected the data into the screen but your selection is not stored anywhere yet, like a webform and when in th emiddle of entering you refresh the screen, entries are gone
  3. only after submit the entries become part of the configflow attributes

The only option I see is to 'submit', run the test and then go back to the screen if the test fails, I could prepopulate this then with the values just selected (i.e. those that failed).

Can you please confirm if I am assuming the correct things?

@jpaulickcz
Copy link
Author

Yes, that is exactly correct. Once I get the message that the selected schedule is incorrect, I have to start over. If it would be possible to go back and re-fill all the selected values, that would of course worked as well :)

@vingerha
Copy link
Owner

Fixed with release 0.5.1

@vingerha
Copy link
Owner

vingerha commented Sep 13, 2024

And with this lightning speed of a solution, maybe you can help with the Czech translation, i.e provide the cz.json ?
No pressure if you donot want to :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants