Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNLogit tests are broken #96

Open
3 tasks
vincentarelbundock opened this issue Apr 30, 2024 · 3 comments
Open
3 tasks

MNLogit tests are broken #96

vincentarelbundock opened this issue Apr 30, 2024 · 3 comments

Comments

@vincentarelbundock
Copy link
Owner

vincentarelbundock commented Apr 30, 2024

Multinomial logit models do not match R.

At first glance, it looks like things work, and there are some tests commented out here:

https://github.com/vincentarelbundock/pymarginaleffects/blob/main/tests/test_statsmodels_mnlogit.py

Things to check:

  • Do the point estimates match?
  • Do the standard errors match?
  • If the SEs don't match, is it because of marginaleffects, or do the fitted models themselves have different covariance matrices? In R you can inspect it with vcov(model). in Python it's usually model.cov_params().
@vincentarelbundock
Copy link
Owner Author

@artiom-matvei you could take a look at this

@artiom-matvei
Copy link
Contributor

@vincentarelbundock It seems like the support for mlogit is deprecated in R. Just double checking before continuing on this issue. https://github.com/vincentarelbundock/marginaleffects/blob/74ef4b3d5a81c83efa3aeff728b9f8eea5681293/NEWS.md?plain=1#L28

@vincentarelbundock
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants