Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_defined_constants types #2616

Closed
orklah opened this issue Jan 13, 2020 · 2 comments
Closed

get_defined_constants types #2616

orklah opened this issue Jan 13, 2020 · 2 comments

Comments

@orklah
Copy link
Collaborator

orklah commented Jan 13, 2020

get_defined_constants has an optional parameter, which, if set to true, will change the output by adding an array level with the category.

The current type in callmap is array<string,int|string|float|bool|null|array|resource>. I guess we could change the type to array<string,int|string|float|bool|null|array|resource>|array<string, array<string,int|string|float|bool|null|array|resource>> But maybe there's a better way to do that which use the value of the parameter?

@psalm-github-bot
Copy link

Hey @orklah, can you reproduce the issue on https://psalm.dev ?

@muglug
Copy link
Collaborator

muglug commented Jan 14, 2020

That's something you could add a PR for with a ReturnTypeProvider, but I'm not going to lose sleep over it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants