MissingPropertyType on third party code (ignoreFiles directory)

[leocavalcante]

lib/third-party.php

class ThirdPartyCode
{
    public $foo;
}

src/index.php

require_once 'lib/third-party.php';

$bar = new ThirdPartyCode();

/** @var int $baz */
$baz = $bar->foo;

ERROR: MissingPropertyType - src\index.php:8:8 - Property ThirdPartyCode::$foo does not have a declared type
$baz = $bar->foo

<?xml version="1.0"?>
<psalm
    totallyTyped="true"
    resolveFromConfigFile="true"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xmlns="https://getpsalm.org/schema/config"
    xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
>
    <projectFiles>
        <directory name="src" />
        <ignoreFiles>
            <directory name="vendor" />
            <directory name="lib" />
        </ignoreFiles>
    </projectFiles>

    <issueHandlers>
        <LessSpecificReturnType errorLevel="info" />
    </issueHandlers>
</psalm>

PS: I'm actually getting this on a third party code inside vendor (regular composer package) this is a code sample that reproduces the issue.

PS 2: Again, sorry if this is me doing bad annotations. Does Psalm have a chat (or something) for such trivial questions like that or it is ok to open issues?

[weirdan]

Looks like a bug to me. Apparently caused by the fact that the error is reported as originating in src/index.php - thus not filtered out.

[muglug]

Looks like a bug to me. Apparently caused by the fact that the error is reported as originating in src/index.php - thus not filtered out.

Not quite - third-party-code or otherwise, Psalm warns when there’s no property type. I think your best bet is to stub the third-party code, adding property types.

[shira-374]

@muglug It looks like a bug to me as well. I'm using totallyTyped="false", hideExternalErrors="true" and ignoring the whole vendor directory, yet I'm getting errors about missing types on some symfony validator constraint props. I'd expect to just get mixed 😕

[muglug]

Yeah, you're right, I was wrong, this is now fixed.