Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction is broken #290

Closed
tyru opened this issue May 4, 2019 · 1 comment
Closed

Transaction is broken #290

tyru opened this issue May 4, 2019 · 1 comment

Comments

@tyru
Copy link
Member

tyru commented May 4, 2019

  • Currently transaction is managed by file-based ($VOLTPATH/trx.lock file)
  • In jsondsl branch (JSON DSL #236), transaction is changed by directory-based ($VOLTPATH/trx/{id}/...) because it's a simple and safe way to limit volt files accesses exclusively across many platforms
  • After that, parallel tests were failed
    • Current exclusive lock implementation does not work completely
  • jsondsl branch is stale, so let's re-implement the directory-based transaction from current devel branch
@tyru
Copy link
Member Author

tyru commented May 26, 2019

#296

  1. Empty lock directory is created $VOLTPATH/trx/lock/
  2. Delete the directory after transaction (something volt modifies files) ends

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant