Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mutate options #35

Open
mpareja opened this issue Feb 1, 2016 · 0 comments
Open

Don't mutate options #35

mpareja opened this issue Feb 1, 2016 · 0 comments

Comments

@mpareja
Copy link

mpareja commented Feb 1, 2016

The passed in options are mutated by express-bunyan-logger. That doesn't work well when you want to share config settings between the standard and error logger.

https://github.com/villadora/express-bunyan-logger/blob/master/index.js#L30

Mutation breaks the following use-case:

var options = { format: ':res[statusCode] :method' };
app.use(logger(options));
  ...
app.use(logger.errorLogger(options));
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant