New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update designer #128

Open

mister-ben opened this issue Apr 21, 2021 · 2 comments

Contributor

mister-ben commented Apr 21, 2021

Designer pen uses Video.js 5.

https://github.com/videojs/videojs.com/blob/379f9b0a2b463c6d56cde5eb3861f5d3754be88a/src/mdx-pages/getting-started.mdx#designing-your-own

Member

heff commented May 16, 2021

I was hoping to just be able to update the version, but because of the skin changes and variables in the codepen SCSS I'm not sure it's that easy.

Should we just remove the designer from the readme?

Contributor Author

mister-ben commented May 29, 2021

Updating the version works. There is also an issue that codepen has changed the class of the style el.

https://codepen.io/mister-ben/pen/ZEepwVo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment