Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting master branch to work with webpack #134

Open
wells opened this issue Dec 28, 2017 · 1 comment
Open

Getting master branch to work with webpack #134

wells opened this issue Dec 28, 2017 · 1 comment

Comments

@wells
Copy link

wells commented Dec 28, 2017

For anyone else wondering how to get the master branch working with a webpack configuration, it is best to avoid trying to use the dist files.

First, install the master branch so you can enjoy the new Vimeo player:

$ yarn add videojs/videojs-vimeo#master

You'll likely hit a Can't resolve 'videojs-vimeo' error with webpack at this point. To resolve import from the src folder:

import videojs from 'video.js'

import 'videojs-vimeo/src/Vimeo'

Using current master also will avoid any TypeError: Cannot read property 'vdata1478551913479' errors if you dispose() the player, which is a bit of a problem in version 2.0.2.

Please note that I am using version 5.20.4 of video.js. I found that the plugins I want to use with the player are not all ready for version 6.x.x.

@dinony
Copy link

dinony commented Jan 8, 2018

Or just install my PR fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants