Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for video.js ^6 greatly appreciated #118

Open
lvl99 opened this issue Jul 25, 2017 · 4 comments
Open

Support for video.js ^6 greatly appreciated #118

lvl99 opened this issue Jul 25, 2017 · 4 comments

Comments

@lvl99
Copy link

lvl99 commented Jul 25, 2017

Aside from the out-of-date NPM package, some work to support the newest version of video.js would be much appreciated.

I had to download the files directly from this repo instead of using NPM, had to install the @vimeo/player dependency after a console error complained it wasn't there, then had to downgrade to video.js v5.20.1 due to errors like it not being able to register as a component because it is a tech.

@krabsheva
Copy link

Had similar errors with the current video.js version. Removing the "registerComponent" line seems to get it working at least on a basic level.

On the minimized version, remove the text:
p.registerComponent("Vimeo",y),

I'm not familiar with the inner workings of video.js or this plugin, so I don't know if there are other version issues.

@seabasss
Copy link

@krabsheva Thanks, removing that line got rid of one error. Now I get this error. Any fix or update for this? TypeError: this.tech_[t] is not a function

@Yeine
Copy link

Yeine commented Oct 12, 2017

Remove this line:
Component.registerComponent('Vimeo', Vimeo);
And support for the 6+ works

@GeyseR
Copy link

GeyseR commented Oct 25, 2017

Here is an opened PR with added videojs 6.x compatibility: #119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants