Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this possible to play ads whenever possible? #520

Open
deepakdevp opened this issue Jul 20, 2020 · 0 comments
Open

Is this possible to play ads whenever possible? #520

deepakdevp opened this issue Jul 20, 2020 · 0 comments

Comments

@deepakdevp
Copy link

Welcome to videojs-contrib-ads and thank you for contributing to the project! Below is a template for filing issues that will help us diagnose problems and recommend solutions.

Description

I would have ads coming from the server and I want to play those ads.

Steps to Reproduce

Include step-by-step instructions on how to reproduce the issue:

  • First step

Expected Results

Describe the behavior you expected here.

Actual Results

Describe the behavior you observed here.

Reproducing Unit Test

Please include a unit test that fails in the most recent version of videojs-contrib-ads but should pass according to your expected results. This will help us understand what the root cause is and separate ad plugin bugs from issues with this project. A unit test can be provided like below:

import QUnit from 'qunit';
import {Midroll} from '../../../src/states.js';
import adBreak from '../../../src/adBreak.js';

QUnit.test('starts an ad break on init', function(assert) {
  this.midroll = new Midroll(this.player);
    
  this.midroll.init(this.player);
  assert.equal(this.player.ads.adType, 'midroll', 'ad type is midroll');
  assert.equal(this.adBreakStartStub.callCount, 1, 'ad break started');
});

This example was pulled from test/states/test.Midroll.js.

Versions

videojs-contrib-ads version: the version of this plugin that you are using.

Video-js version: the version of videojs you are using. If you are using npm, you can check this by running npm ls video.js --depth=0 in your project.

Other plugins: please list other plugins that may affect videojs-contrib-ads behavior, especially ad plugins.

Platforms

Browsers: eg. Chrome v56

OS/Devices: eg. Windows 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant