Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lang): Arabic translation grammar, spelling and vocabulary errors #8724

Merged
merged 2 commits into from
May 30, 2024

Conversation

mohammadmansour200
Copy link
Contributor

Description

Unfortunately there was many obvious and big errors in the Arabic translation, so I proceeded to fix them.

Specific Changes proposed

  • Fixed spelling errors
  • Fixed grammatical errors
  • Fixed spelling errors

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

Copy link

welcome bot commented May 9, 2024

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.15%. Comparing base (7b0aede) to head (58c3c15).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8724   +/-   ##
=======================================
  Coverage   83.15%   83.15%           
=======================================
  Files         120      120           
  Lines        7995     7995           
  Branches     1924     1924           
=======================================
  Hits         6648     6648           
  Misses       1347     1347           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mister-ben mister-ben changed the title Fix Arabic translation grammar, spelling and vocabulary errors fix(lang): Arabic translation grammar, spelling and vocabulary errors May 14, 2024
@mister-ben mister-ben added the needs: LGTM Needs one or more additional approvals label May 14, 2024
@mohammadmansour200
Copy link
Contributor Author

@mister-ben is there anything I can do to help ship this PR faster?

Copy link
Contributor

@adrums86 adrums86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. LGTM!

@adrums86 adrums86 merged commit ad357b5 into videojs:main May 30, 2024
11 of 12 checks passed
@mohammadmansour200
Copy link
Contributor Author

Sorry for the delay. LGTM!

No probs

@mohammadmansour200 mohammadmansour200 deleted the patch-1 branch May 31, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: LGTM Needs one or more additional approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants