-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use URL API #8716
Merged
Merged
refactor: use URL API #8716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8716 +/- ##
==========================================
- Coverage 83.00% 82.97% -0.04%
==========================================
Files 120 120
Lines 7998 7978 -20
Branches 1927 1921 -6
==========================================
- Hits 6639 6620 -19
+ Misses 1359 1358 -1 ☔ View full report in Codecov by Sentry. |
amtins
reviewed
Apr 30, 2024
amtins
approved these changes
Apr 30, 2024
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaces some now unnecessary fallbacks with the standard
URL
API.parseUrl
new returns an actualURL
instead of aURL
-like object.Updates tests slightly:
getAbsoluteURL()
to matchURL
's behaviour with trailing slashes, and use aURL
object in the cross origin tests.Adds a test for
getAbsoluteURL()
with a relative URLRequirements Checklist