Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved error interface #8564

Merged
merged 13 commits into from
Jan 25, 2024
Merged

feat: improved error interface #8564

merged 13 commits into from
Jan 25, 2024

Conversation

wseymour15
Copy link
Contributor

@wseymour15 wseymour15 commented Jan 19, 2024

Description

Changes to the MediaError class so we can expect a metadata property on this class, as well as creating a list of error types.

Specific Changes proposed

  • Update of the MediaError class so jsdoc generates TS types for error types, as well as adding a new metadata property so we can give greater specificity to errors.
  • Create a list of error types set on the video.js object to be reused throughout video.js and for developer usage.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6fe68e5) 83.44% compared to head (bfa6e36) 82.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8564      +/-   ##
==========================================
- Coverage   83.44%   82.74%   -0.70%     
==========================================
  Files         113      113              
  Lines        7615     7626      +11     
  Branches     1830     1830              
==========================================
- Hits         6354     6310      -44     
- Misses       1261     1316      +55     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/js/video.js Outdated Show resolved Hide resolved
src/js/player.js Outdated Show resolved Hide resolved
src/js/media-error.js Outdated Show resolved Hide resolved
@wseymour15 wseymour15 marked this pull request as ready for review January 23, 2024 16:16
@wseymour15 wseymour15 self-assigned this Jan 23, 2024
@wseymour15 wseymour15 merged commit 43941a8 into main Jan 25, 2024
12 of 13 checks passed
@wseymour15 wseymour15 deleted the feat/improved-error-interface branch January 25, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants