Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in 8.x version vide.js/dist/video.js includes es6 syntax,webpack error #8205

Closed
smithyj opened this issue Mar 22, 2023 · 2 comments
Closed
Labels
bug needs: triage This issue needs to be reviewed

Comments

@smithyj
Copy link

smithyj commented Mar 22, 2023

Description

in 8.x version vide.js/dist/video.js includes es6 syntax,webpack error

Reduced test case

No response

Steps to reproduce

1.in 8.x version vide.js/dist/video.js includes es6 syntax,webpack error
2.
3.

Errors

No response

What version of Video.js are you using?

8.0.4

Video.js plugins used.

No response

What browser(s) including version(s) does this occur with?

Chrome 100

What OS(es) and version(s) does this occur with?

Mac

@smithyj smithyj added bug needs: triage This issue needs to be reviewed labels Mar 22, 2023
@welcome
Copy link

welcome bot commented Mar 22, 2023

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@mister-ben
Copy link
Contributor

Webpack/Babel's transpiling of ES6 classes can break Video.js. See this comment for how to ensure that the classes are left intact.

@smithyj smithyj closed this as completed Mar 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug needs: triage This issue needs to be reviewed
Projects
None yet
Development

No branches or pull requests

2 participants