Set the 'lang' attribute on text track display elements, if the language of the track is known #7493
Conversation
…age of the track is known
OwenEdwards
added
the
a11y
Codecov Report
@@ Coverage Diff @@
## main #7493 +/- ##
==========================================
- Coverage 79.72% 79.72% -0.01%
==========================================
Files 116 116
Lines 7296 7298 +2
Branches 1754 1755 +1
==========================================
+ Hits 5817 5818 +1
- Misses 1479 1480 +1
Continue to review full report at Codecov.
|
|
I wish I knew how to add a test for this change, in part so that it doesn't make the code coverage (fractionally) worse, but I don't! Does anyone want to add a test to this? |
|
@OwenEdwards got some tests for this here OwenEdwards#3 |
|
This also fixes this problem I didn't realise we have that Chinese glyphs could be used incorrectly with Japanese subs, if the player language isn't Japanese. https://heistak.github.io/your-code-displays-japanese-wrong/ |
* add some tests * update test naming
|
lol, not sure why CI doesn't want to re-run stuff. Maybe I should've made the PR from my fork instead. |
|
The code coverage went a tiny bit up. |
…language of the track is known (videojs#7493) Fixes videojs#7487 Co-authored-by: Gary Katsevman <[email protected]>
Description
Fixes #7487
Requirements Checklist