Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clear up reference if component is unmounted #7433

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Fix clear up reference if component is unmounted #7433

merged 1 commit into from
Nov 10, 2021

Conversation

jomarquez21
Copy link
Contributor

@jomarquez21 jomarquez21 commented Sep 20, 2021 •
edited
Loading

Description

Improve documentation on functional components to clean up reference if the component is unmounted.
#7361

Specific Changes proposed

Please list the specific changes involved in this pull request.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@welcome
Copy link

welcome bot commented Sep 20, 2021

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@jomarquez21 jomarquez21 changed the title Fix clear when unmount component Fix clear up reference if component is unmounted Sep 20, 2021
@jomarquez21 jomarquez21 force-pushed the fix-react-documentation branch from 9ed5c1f to b1b2088 Compare September 20, 2021 13:29
@jomarquez21 jomarquez21 force-pushed the fix-react-documentation branch from b1b2088 to ac51417 Compare September 20, 2021 13:30
@gkatsev gkatsev added the needs: LGTM Needs one or more additional approvals label Nov 10, 2021
@gkatsev gkatsev merged commit fdb87d8 into videojs:main Nov 10, 2021
@welcome
Copy link

welcome bot commented Nov 10, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@misteroneill misteroneill removed the needs: LGTM Needs one or more additional approvals label Nov 10, 2021
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
@jomarquez21 @edirub
docs(react): fix clear when unmount component (videojs#7433)
b46146b 
Improve documentation on functional components to clean up reference if the component is unmounted.

Fixes videojs#7361
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev approved these changes

@misteroneill misteroneill misteroneill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jomarquez21 @misteroneill @gkatsev