Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a code coverage ci workflow #7282

Merged
merged 5 commits into from
Jun 23, 2021
Merged

chore: add a code coverage ci workflow #7282

merged 5 commits into from
Jun 23, 2021

Conversation

brandonocasey
Copy link
Contributor

Description

Get code coverage working again.

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@1fc1c58). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7282   +/-   ##
=======================================
  Coverage        ?   79.44%           
=======================================
  Files           ?      115           
  Lines           ?     7264           
  Branches        ?     1745           
=======================================
  Hits            ?     5771           
  Misses          ?     1493           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fc1c58...f3d0f5b. Read the comment docs.

@gkatsev
Copy link
Member

gkatsev commented Jun 23, 2021

Pleasantly surprised, our code coverage isn't a lot lower than ~80%.

@gkatsev
Copy link
Member

gkatsev commented Jun 23, 2021

Enabled codecov's app, so, should have nicer reporting. Enabled it for all repos, so, we don't need to do that when/if we add coverage to other repos.

@gkatsev gkatsev merged commit 4cecbda into main Jun 23, 2021
@gkatsev gkatsev deleted the chore/code-coverage branch June 23, 2021 04:53
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants