Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attaching instead of detaching an event listener #7258

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Fix attaching instead of detaching an event listener #7258

merged 1 commit into from
Jun 2, 2021

Conversation

boris-petrov
Copy link
Contributor

Description

I believe this is a bug. In dispose event listeners should be detached instead of reattached.

Specific Changes proposed

Changed on to off.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@welcome
Copy link

welcome bot commented Jun 2, 2021

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@gkatsev gkatsev added the needs: LGTM Needs one or more additional approvals label Jun 2, 2021
@misteroneill misteroneill removed the needs: LGTM Needs one or more additional approvals label Jun 2, 2021
@gkatsev gkatsev merged commit c70c298 into videojs:main Jun 2, 2021
@welcome
Copy link

welcome bot commented Jun 2, 2021

Congrats on merging your first pull request! 🎉🎉🎉

edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
We were accidentally listening to `liveedgechange` when the seek-bar disposed. Instead, we should remove that event handler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants