fix: Remove extra timeupdate event when progress controls disabled #7142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-barstow
force-pushed
the
fix-rogue-timeupdate-when-progress-controls-disabled
branch
from
286db9e to
42cad3a
Compare
Should we make sure that we have started before we try to trigger |
gkatsev
approved these changes
Mar 23, 2021
brandonocasey
approved these changes
Mar 23, 2021
alex-barstow
deleted the
fix-rogue-timeupdate-when-progress-controls-disabled
branch
edirub
pushed a commit
to edirub/video.js
that referenced
this pull request
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SeekBar.handleMouseUp()is a side-effect of disabling progress controls viaProgressControls.disable(). This is an issue becauseSeekBar.handleMouseUp()manually triggers a'timeupdate'event (because it assumes a seek has just taken place). If someone attempts to disable the progress controls before playback starts, a'timeupdate'will fire potentially before we even have'loadedmetadata', which can cause problems.Specific Additions
disable()method fromhandleMouseUp()into its own function.ProgressControls.disable()will resume a normal playback state if it is invoked while the player is scrubbing.