fix: prevent dispose error and text track duplicate listeners #6984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
commented
Dec 7, 2020
| @@ -241,12 +248,10 @@ class TextTrack extends Track { | |||
| // On-demand load. | |||
| loadTrack(this.src, this); | |||
| } | |||
| this.tech_.off('timeupdate', timeupdateHandler); | |||
There was a problem hiding this comment.
Should we also return early in this function if the mode is the same as the current mode? Is there a reason we trigger modechange when a track goes from disabled to disabled again?
There was a problem hiding this comment.
Making this change makes sense. I think we'd want to see whether doing that causes any issues for the captions menu, though, I doubt it.
|
Is there a specific timing for adding the throttling? I've tried it and cannot reproduce. I think this hasn't really come up previously because the menu itself prevents changing the mode to the same item already. It's only an issue programmatically. |
gkatsev
reviewed
Jan 11, 2021
src/js/tracks/text-track.js
Outdated
Comment on lines
204
to
207
| this.tech_.off('dispose', disposeHandler); | ||
| }; | ||
|
|
||
| this.tech_.on('dispose', disposeHandler); |
brandonocasey
force-pushed
the
fix/text-track-duplicate-updates
branch
from
5ce1af2 to
e6dda7c
Compare
gkatsev
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed an error when disposing a player with text tracks on and was able to replicate it on our standard simple demo by turning on throttling to 6x in chrome and disposing the player with the default text track on. I also noticed that we do two other things:
showingmore then once in a text track we add another update handler, without a limit to how many we can add.