feat: Allow click handler to be specified in clickable component's options #6140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
added
the
minor
gkatsev
reviewed
Aug 1, 2019
| }); | ||
| const el = testClickableComponent.el(); | ||
|
|
||
| Events.trigger(el, 'click'); |
There was a problem hiding this comment.
can we add a test that if we trigger a space or enter key on it, the click handler gets called?
gkatsev
approved these changes
Aug 29, 2019
This was referenced Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow a clickable component's click handler to be passed as a constructor option as a simple alternative to creating a custom component.
Makes for easier answers to "how do I create a button questions".
Specific Changes proposed
Add
clickHandleras an option for ClickableComponentAll player controls override the
handleClickmethod so are unaffected.Requirements Checklist