Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create vue.md #5899

Merged
merged 2 commits into from
Mar 28, 2019
Merged

Create vue.md #5899

merged 2 commits into from
Mar 28, 2019

Conversation

chopfitzroy
Copy link
Contributor

Instructions for Vue integration (based on React example).

Description

Documentation update.

Specific Changes proposed

Added vue.md to docs/guides

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

Instructions for Vue integration (based on React example).
@welcome
Copy link

welcome bot commented Mar 27, 2019

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@chopfitzroy chopfitzroy mentioned this pull request Mar 27, 2019
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
This is great.

Would you be able to add a link in this section? https://github.com/videojs/video.js/blob/master/docs/guides/player-workflows.md#using-videojs-with

@chopfitzroy
Copy link
Contributor Author

Hey @gkatsev that should do it, let me know if I have done anything wrong been a while since I submitted a PR.

@gkatsev
Copy link
Member

gkatsev commented Mar 28, 2019

Perfect, thanks!

@gkatsev gkatsev merged commit 4c277fd into videojs:master Mar 28, 2019
@welcome
Copy link

welcome bot commented Mar 28, 2019

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants