Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find a empty box #5564

Closed
finebo opened this issue Nov 8, 2018 · 9 comments
Closed

find a empty box #5564

finebo opened this issue Nov 8, 2018 · 9 comments
Labels
outdated Things closed automatically by stalebot

Comments

@finebo
Copy link

finebo commented Nov 8, 2018

image

Click play button and then an empty box appears when video loads

@welcome
Copy link

welcome bot commented Nov 8, 2018

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@gkatsev
Copy link
Member

gkatsev commented Nov 8, 2018

That looks like the border of an iframe element. We use an iframe element when ResizeObserver isn't available. You can disable it by passing in resizeManager: false option to the player.
Does video still play or do you get a blank video?

@finebo
Copy link
Author

finebo commented Nov 11, 2018

I've got video, this is what it looks like when it's initialized, and you can still see the border when it's played on video
image

@gkatsev
Copy link
Member

gkatsev commented Nov 11, 2018

Can you try version 7.3.0? We had a fix related to it: #5522

@finebo
Copy link
Author

finebo commented Nov 12, 2018

I'm sorry that this problem still exists. The version I'm using now is 7.3.0, mainly focused on the iphone, and most android phones are available

@gkatsev
Copy link
Member

gkatsev commented Nov 13, 2018

Oh, I see. I think it's happening because we didn't turn off the border for iframes. As a workaround, you can turn off the resizeManager until it is fixed.

@gkatsev
Copy link
Member

gkatsev commented Nov 14, 2018

Looking into this, it seems like we properly set up the ResizeManager iframe to not have a border. In 7.3.0, we changed how the ResizeManager iframe is done: #5522.
Would you be able to provide a reduced test case? I am having a hard time reproducing it locally. I'm guessing that it's some styles on the page conflicting with our styles for the iframe. Any CSS frameworks used on the page?

@finebo
Copy link
Author

finebo commented Nov 15, 2018

Today I created a new demo, and the frame did not appear again, probably because I just updated VJS version to 7.3.0 last time,But no update it min. CSS file, this is my demo address videTest, thanks again for your help!!!
This demo also shows some other issues on android phones, in China a lot of browsers are x5 cores,
On these browsers VJS is so high up when they play video that there's nothing to cover them,
My tests on chrome and firefox are good, but running on the browsers of Wechat and Tencent creates a hierarchy problem.
I feel very helpless, because there is no way around tencent in China

@gkatsev gkatsev removed the confirmed label Nov 15, 2018
@stale
Copy link

stale bot commented Jan 14, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the outdated Things closed automatically by stalebot label Jan 14, 2019
@stale stale bot closed this as completed Jan 22, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated Things closed automatically by stalebot
Projects
None yet
Development

No branches or pull requests

2 participants