Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typos in cs translation #5407

Merged
merged 2 commits into from
Sep 4, 2018
Merged

Fixed typos in cs translation #5407

merged 2 commits into from
Sep 4, 2018

Conversation

Akxe
Copy link
Contributor

@Akxe Akxe commented Aug 31, 2018

Lang file edit only

Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One super minor thing. Otherwise, I'm sure your Czech is better than mine! 👍

lang/cs.json Outdated
"End of dialog window.": "Konec dialogového okna.",
"{1} is loading.": "{1} se načítá."
"{1} is loading.": "{1} se načítá.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing , is invalid JSON.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is that? It would be better for diffs, no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just how JSON is. With the trailing comma, JSON.parse() will throw an error. It comes from the bad old days when certain JS engines would choke on trailing commas.

Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@misteroneill misteroneill added the needs: LGTM Needs one or more additional approvals label Aug 31, 2018
@gkatsev gkatsev merged commit 19ee7df into videojs:master Sep 4, 2018
@gkatsev gkatsev removed the needs: LGTM Needs one or more additional approvals label Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants