VideoJS component for Bower

[lukebussey]

I'm requesting that video.js be made into a Bower component so that it can simply be installed using the command bower install -save videojs. Currently it can be installed but can't be used without first building, which is an extra step in the workflow.

All it would take is to add the following code into a bower.json file and committing the dist directory.

{
  "name": "video.js",
  "description": "An HTML5 and Flash video player with a common API and skin for both.",
  "version": "4.0.1",
  "copyright": "Copyright 2013 Brightcove, Inc. https://github.com/videojs/video.js/blob/master/LICENSE"
}

Any chance of this happening?

Thanks,
Luke

[heff]

There's a few issues with committing the compiled code.

• Merge conflicts/duplicated changes with every pull request
• People inevitably make pull requests against the compiled code instead of the source

I attempted to create an alternative repo, and registered with that. Does it work for you?

bower install video.js

https://github.com/videojs/video.js-component

[lukebussey]

An alternative repo is perfect. It just needs a semver tag to work. Could you tag it "4.0.1"?

[heff]

Tags pushed. Let me know if that works.

On May 23, 2013, at 7:55 PM, lukebussey [email protected] wrote:

An alternative repo is perfect. It just needs a semver tag to work. Could you tag it "4.0.1"?

—
Reply to this email directly or view it on GitHub.

[lukebussey]

Works great! I'll request the other repo removed from the bower component repository.

[heff]

There's another one?

On May 30, 2013, at 2:18 PM, lukebussey [email protected] wrote:

Works great! I'll request the other repo removed from the bower component repository.

—
Reply to this email directly or view it on GitHub.

[slobo]

There is videojs listed in bower registry, pointing to the main repo (i.e. useless). Might be nice to mention in some readme somewhere, had me chasing around for a bit.

$ bower search videojs
Search results:

    videojs git://github.com/videojs/video.js.git
...

$ bower search video.js
Search results:

    video.js git://github.com/videojs/video.js-component.git

[heff]

It'd be great to delete that one, but there's still no way to delete stuff from bower, yeah?

[gkatsev]

You can request to get it deleted but yeah, basically you can't get rid of anything.

[heff]

FYI, we're going to be moving back to using the main repo for bower, once we get #874 pulled in.

[DeanMarkTaylor]

@heff What's the status of this?
It seems broken at the moment:

• Create a version task #874 has been closed without inclusion of the version updating
• The component repo is out of date: https://github.com/videojs/video.js-component
• The tags don't match the actual bower.json version
  ** Tag 4.5.1 vs bower.json 4.4.3 - https://github.com/videojs/video.js/blob/v4.5.1/bower.json

[gutenye]

And the dist files are removed from main repo efe25c0, how to install via bower now?

[blueyed]

bower install videojs/video.js appears to work with 4.5.2 (the tag is fixed):

INFO:config.settings:Base settings loaded: <Configuration 'config.settings.Dev'>
bower video.js#*                cached https://github.com/videojs/video.js.git#4.3.0
bower video.js#*              validate 4.3.0 against https://github.com/videojs/video.js.git#*
bower video.js#*                   new version for https://github.com/videojs/video.js.git#*
bower video.js#*               resolve https://github.com/videojs/video.js.git#*
bower video.js#*              download https://github.com/videojs/video.js/archive/v4.5.2.tar.gz
bower video.js#*               extract archive.tar.gz
bower video.js#*              resolved https://github.com/videojs/video.js.git#4.5.2
bower video.js#~4.5.2          install video.js#4.5.2

video.js#4.5.2 bower_components/video.js

% ls bower_components/video.js/dist/video-js 
demo.captions.vtt  demo.html  font  video.dev.js  video.js  video-js.css  video-js.less  video-js.min.css  video-js.swf

/cc @gutenye @DeanMarkTaylor

[heff]

I think bower video.js still points to the videojs-component repo, which is deprecated and we need to update that.

[uxtx]

Any luck updating bower to point to the correct component? As is, we're having to reference the full git path, as bower only points to the component repo for both videojs and video.js.

Thanks

[gkatsev]

I believe it should be updated. Can you try and let us know if its still not the case?

[uxtx]

Figured it out. Its a problem of video.js version 4.3 apparently it doesn't ship with a /dist folder, just the raw components.

[uxtx]

for the time being, i guess we'll need to stick with git full path

[heff]

@uxtx, is the problem that you can't upgrade the video.js version? I just bower installed both videojs and video.js and both point to the right repo.

Also, hi Dave. :)

[uxtx]

Hi @heff, thanks for sharing some clue here. That's correct, it's a problem with this version. We're planning on upgrading in the roadmap, but needed to do some regression testing first... i guess maybe we need to move up the timeline ;) .

Anyhow, ya I think the issue is specific to the version I'm targeting. I've attached my bower.json for reference. When i install with this version targeted, no dist file is listed, just the components.

{
  "name": "test",
  "description": "test",
  "keywords": [
    "foo"
  ],
  "license": "MIT",
  "dependencies": {
    "videojs": "4.3"
  }
}

Thanks again, and hope all is well for you and yours!

[gkatsev]

Totally makes sense for older versions to not have a dist folder since it's before we migrated to this repo and started checking in the dist for deploys.

[uxtx]

that makes sense. I'll just point to the videojs-components git repo then for the short term, until we're ready to upgrade. Thanks again guys.