feat(middleware): make setSource be optional #5295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but docs/guides/middleware.md will need to be updated. |
|
Good call, I'll update docs tomorrow. |
|
docs updated |
misteroneill
approved these changes
Jul 6, 2018
ldayananda
approved these changes
Jul 6, 2018
docs/guides/middleware.md
Outdated
| @@ -37,6 +38,8 @@ videojs.use('*', function(player) { | |||
| }); | |||
| ``` | |||
|
|
|||
| Alternative, in versions greater than 7.0.5, you may omit `setSource` entirely and the middleware will get selected implicitly. | |||
There was a problem hiding this comment.
I would just put this above the explanation of how to pass along the source, since it'll be default behavior from now on
gkatsev
added a commit
that referenced
this pull request
Jul 9, 2018
setSource is useful if you care to be fiddling with the source or doing some work depending on what source is set. However, sometimes, you don't need a setSource and want the middleware to always be selected. Now, if setSource is missing, it will implicitly be included in the middleware chain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tests first and implementation will be available after tests fail.
setSource is useful if you care to be fiddling with the source or doing some work depending on what source is set. However, sometimes, you don't need a setSource and want the middleware to always be selected.
Now, if setSource is missing, it will implicitly be included in the middleware chain.