Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for el before resetSourceSet #5176

Merged
merged 1 commit into from
May 16, 2018
Merged

Conversation

brandonocasey
Copy link
Contributor

Fixes #5175

@thijstriemstra
Copy link
Contributor

thijstriemstra commented May 15, 2018

Can this be reproduced in a test (that can verify dispose better)? Because I've seen other issues with dispose, while writing unit tests for a plugin, and having a test that catches them all would be nice. Basically a test that does not wait for the player html elements to tear down; so once created, dispose and go to next test (triggering these cleanup issues).

A call to dispose should basically never trigger an error IMO, and this fix does not guarantee prevention of introducing similar bugs because there's no test reproducing this.

@brandonocasey
Copy link
Contributor Author

Going to make a new pr with the suggested unit test @thijstriemstra, as we do want to prevent these issues in the future 👍

@brandonocasey brandonocasey merged commit 59c6261 into master May 16, 2018
@brandonocasey
Copy link
Contributor Author

PR for reference #5179

@brandonocasey brandonocasey deleted the fix/sourceset-el-check branch May 16, 2018 16:38
@thijstriemstra
Copy link
Contributor

awesome @brandonocasey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants