Remove unnecessary ARIA role on the Control Bar. Fixes #5134 #5154
Conversation
src/js/control-bar/control-bar.js
Outdated
| @@ -40,9 +40,6 @@ class ControlBar extends Component { | |||
| className: 'vjs-control-bar', | |||
| dir: 'ltr' | |||
| }, { | |||
There was a problem hiding this comment.
we can just get rid of this object entirely, if we aren't using it.
|
So you think that the control bar should just not have a role? I guess it makes sense since you never interact with the control bar itself. |
|
@gkatsev I did some testing, and there just doesn't seem to be any point in indicating the Control Bar as a separate object - it's all just part of the video player. Perhaps in the future, if there's content which isn't part of the control bar that needs to be clearly distinguishable from the control bar, then it would make sense, but right now you don't interact with the control bar and it doesn't convey any concept of grouping. For example, is it semantically important that the BPB isn't part of the control bar? I don't think it is. To answer your other question, yes - this should also be ported to master; I wasn't sure if it was better to start there and back-post, or vice versa. Let me know if you want me to switch it. |
|
Makes sense. Either way is fine. We can easily port for master when merged. |
There doesn't seem to be any point in indicating the Control Bar as a separate object - it's all just part of the video player. Perhaps in the future, if there's content which isn't part of the control bar that needs to be clearly distinguishable from the control bar, then it would make sense, but right now you don't interact with the control bar and it doesn't convey any concept of grouping. Fixes #5134
Description
Remove unnecessary ARIA role on the Control Bar. Fixes #5134
Requirements Checklist