Fix IDs and ARIA attributes in Captions Settings Dialog #5153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttings Dialog (fixes videojs#4688 and videojs#4884)
OwenEdwards
added
a11y
gkatsev
approved these changes
May 8, 2018
gkatsev
approved these changes
May 8, 2018
gkatsev
pushed a commit
that referenced
this pull request
May 11, 2018
OwenEdwards
deleted the
fix/ids-and-aria-attributes-in-captions-settings-dialog
branch
OwenEdwards
restored the
fix/ids-and-aria-attributes-in-captions-settings-dialog
branch
OwenEdwards
deleted the
fix/ids-and-aria-attributes-in-captions-settings-dialog
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove spaces in the element IDs and ARIA attributes in the Captions Settings Dialog.
Fixes #4688 and #4884; supercedes 855adf3.
Specific Changes proposed
Remove spaces in the construction of IDs and aria-labelledby attributes in the Captions Settings Dialog constructor.
Requirements Checklist