Moving seekbar event handler bindings into a function #5097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Makes it easier to extend the seekbar and change modify the default event handlers no message
|
Assuming this gets in, will this and #5055 make it into 6.x or are these only for 7.x? Is there anything I need to do for them to get into 6.x? |
guided1
changed the title
guided1
changed the title
gkatsev
reviewed
Apr 13, 2018
| * | ||
| * @private | ||
| */ | ||
| setEventHandlers_(player, options) { |
There was a problem hiding this comment.
I would consider removing passing in the player and options and instead update the code to use this.player_ and this.options_
- Using member variables instead of passing through arguments.
brandonocasey
approved these changes
Apr 19, 2018
gkatsev
added
confirmed
and removed
needs: LGTM
gkatsev
pushed a commit
that referenced
this pull request
Apr 19, 2018
Makes it easier to extend the seekbar and change the default event handlers. If you extend the seekbar component you can choose to override setEventHandlers_ or keep it default. If you do override setEventHandlers_ and call super() in the constructor, you get your own event handlers + the functionality provided by Slider.
gkatsev
pushed a commit
that referenced
this pull request
Apr 20, 2018
Makes it easier to extend the seekbar and change the default event handlers. If you extend the seekbar component you can choose to override setEventHandlers_ or keep it default. If you do override setEventHandlers_ and call super() in the constructor, you get your own event handlers + the functionality provided by Slider.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move all eventHandler bindings into a function.
Specific Changes proposed
This allows for easier customisation of the the seekbar component.
If you extend the seekbar component you can choose to override
setEventHandlers_or keep it default.If you do override
setEventHandlers_and callsuper()in the constructor, you get your own event handlers + the functionality provided bySliderCurrently extending slider and wanting different bindings, means either copy pasting from the existing slider or writing a function to undo the bindings (which is not possible in this case since they are anonymous functions).
Requirements Checklist