fix: remove CaptionsSettingsMenuItem when TextTrackSetting is not inc…

[vsoren]

Description

Removes the CaptionsSettingsMenuItem when TextTrackSettings is not included.

Fixes #4996

Requirements Checklist

• Feature implemented / Bug fixed
• If necessary, more likely in a feature request than a bug fix
  • Change has been verified in an actual browser (Chome, Firefox, IE)
  • Unit Tests updated or fixed
  • Docs/guides updated
  • Example created (starter template on JSBin)
• Reviewed by Two Core Contributors

[ldayananda]

Thanks for the PR @vsoren! Looks like you found some out of date tests-- if you take a look at the source code and then the tests that fail, you'll notice that '.vjs-texttrack-settings' should really be '.vjs-text-track-settings'

[ldayananda]

In fact, specifically for the first test that fails , it doesn't seem like text-track-settings.test.js is right place for it. It should probably be removed and rewritten for the CaptionsSettingsMenuItem.

For this PR, I would be ok with removing that first test.

[ldayananda]

Thanks for the PR!

This looks good to me. Once another core contributor approves, we'll include it in an upcoming release.

[gkatsev]

So, after looking at this, I think we want to change the way the tests are. The tests look for the caption settings menu item and then "click" it to open the modal dialog. With this fix, we don't have a default caption settings menu item unless there are captions that are emulated. I'll make a PR for the test fixes.

[gkatsev]

I guess it just started failing because we weren't adding it unconditionally anymore.
@vsoren I made a PR against your branch (vsoren#1), once you merge that PR, we can merge this PR in!

[vsoren]

@gkatsev The PR on my branch has been merged. :)

[gkatsev]

@vsoren thanks!