Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugins.md #4951

Closed
1 of 5 tasks
first-timers bot opened this issue Feb 12, 2018 · 4 comments
Closed
1 of 5 tasks

Update plugins.md #4951

first-timers bot opened this issue Feb 12, 2018 · 4 comments

Comments

@first-timers
Copy link

first-timers bot commented Feb 12, 2018

πŸ†•πŸ₯☝ First Timers Only.

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you πŸ’

About First Timers Only.

πŸ€” What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

πŸ“‹ Step by Step

  • πŸ™‹ Claim this issue: Comment below.

  • πŸ“ Update the file docs/guides/plugins.md in the video.js repository (press the little pen Icon) and edit the line as shown below.

@@ -246,7 +246,7 @@ Note that the [plugin generator](https://github.com/videojs/generator-videojs-pl
 
 ### Advanced Example Advanced Plugin
 
-What follows is a complete ES6 advanced plugin that logs a custom message when the player's state changes between playing and paused. It uses all the described advanced features:
+What follows is a complete ES6 advanced plugin that logs a custom message when the player's state changes between playing and pause. It uses all the described advanced features:
 
 ```js
 import videojs from 'video.js';
@@ -258,7 +258,7 @@ class Advanced extends Plugin {
   constructor(player, options) {
     super(player, options);
 
-    // Whenever the player emits a playing or paused event, we update the
+    // Whenever the player emits a playing or pause event, we update the
     // state if necessary.
     this.on(player, ['playing', 'pause'], this.updateState);
     this.on('statechanged', this.logState);
  • πŸ’Ύ Commit your changes

  • πŸ”€ Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can edit files directly in your browser

  • 🏁 Done Ask in comments for a review :)

πŸ€”β“ Questions

Leave a comment below!

This issue was created by First-Timers-Bot.

@jessdvdv
Copy link
Contributor

jessdvdv commented Feb 13, 2018

Hi! I would like to claim this issue. Is it taken yet? I'm a beginner. I read through the CONTRIBUTING.md doc already. Let me know the best way to get started. Would love to assist. Thank you!

@misteroneill
Copy link
Member

Hi @jessicaweberdev - this issue is all yours! Your help would be greatly appreciated and this issue is an ideal way to get started.

The next step is to make an actual change to the file in question, docs/guides/plugins.md, which you can do directly on the GitHub website (by clicking the pen toward the top-right of that page) or, if you're comfortable with trying, you can follow the instructions linked above to fork and clone Video.js.

The changes requested are outlined in the diff above (with the green and red text). In this case, it's looking for changes to two lines - replacing the word "paused" with "pause" where appropriate.

If you have trouble or further questions, feel free to comment here or reach out on our Slack channel.

Looking forward to having you as a contributor!

@jessdvdv
Copy link
Contributor

Hi there! I sent a pull request. Updates complete. Looking forward to the next issue to work on! Let me know if I can further assist. :) Thank you so much!

@gkatsev
Copy link
Member

gkatsev commented Feb 14, 2018

Thanks @jessicaweberdev! Look out for more first-timers-only issues or other help-wanted issues. I'm going to try and create more of these issues along with other simple tasks.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants