chore: generate a test example on netlify on PRs #4912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IT WORKED! https://deploy-preview-4912--videojs-docs.netlify.com/test-example/ |
gkatsev
commented
Jan 29, 2018
| @@ -449,7 +448,6 @@ module.exports = function(grunt) { | |||
| 'cssmin', | |||
|
|
|||
| 'copy:fonts', | |||
| 'copy:swf', | |||
There was a problem hiding this comment.
our switch to node 8/npm 5 meant that packages were flattened, so, the swf snuck back into the dist folder.
| @@ -16,4 +17,9 @@ if (process.env.BRANCH === 'master' && semver.valid(output.trim()) === null) { | |||
|
|
|||
| // copy the legacy docs over | |||
| sh.cp('-R', 'docs/legacy-docs', 'docs/api/docs'); | |||
|
|
|||
| if (process.env.BRANCH !== 'master') { | |||
There was a problem hiding this comment.
there's no need or want to generate this in the master branch currently, I don't think.
|
|
||
| // copy the `dist` dir | ||
| sh.cp('-R', 'dist', path.join(dest, 'dist')); | ||
| sh.rm(path.join(dest, 'dist', `video-js-${pkg.version}.zip`)); |
There was a problem hiding this comment.
we don't need the zip file published here.
sandbox/icons.html.example
Outdated
| @@ -4,7 +4,7 @@ | |||
| <meta charset="utf-8" /> | |||
| <title>Video.js Icons Sandbox</title> | |||
|
|
|||
| <link href="../build/temp/video-js.css" rel="stylesheet" type="text/css"> | |||
| <link href="../build/video-js.css" rel="stylesheet" type="text/css"> | |||
There was a problem hiding this comment.
Is this one intentionally using build instead of dist?
There was a problem hiding this comment.
nope. Probably got confused about it, heh.
misteroneill
approved these changes
Jan 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, we get a small PR that has code that's good but testing it means that we have to check out the code locally. This should generate a
test-examplefolder on the docs site for the PR with a built version of Video.js from the PR.Hopefully, this PR will be the the very first example of it too.