feat: Add videojs.getAllPlayers to get an array of players.

[misteroneill]

When working on another PR, I noticed that there were tests somewhere not completely cleaning up after themselves. Then, I thought, wouldn't it be nice to be able to delegate method calls to all players, so we could dispose them?

This new function makes that easier:

videojs.getAllPlayers().forEach(p => p.dispose());

Previously, you'd have to do something like:

Object.keys(videojs.players).map(k => videojs.players[k]).filter(Boolean).forEach(p => p.dispose());

Requirements Checklist

• Feature implemented / Bug fixed
• If necessary, more likely in a feature request than a bug fix
  • Change has been verified in an actual browser (Chome, Firefox, IE)
  • Unit Tests updated or fixed
  • Docs/guides updated
• Reviewed by Two Core Contributors

[gkatsev]

I'm for adding these but against this API. Having it return an array of players when called via .all() and then call the players when called via .all('dispose') is confusing and inconsistent.
What about keeping the calling functionality for calling methods and moving the returning the array to a .getAllPlayers() method? Also, potentially move the calling to something like .playersDo(), which has precedent in vim and similar functionality like :tabdo and :bufdo where you do something for each tab.

[misteroneill]

Yeah, I don't disagree. I had similar thoughts.

I like getAllPlayers for getting an array, but playersDo seems confusing to me. Maybe callAllPlayers or delegateAllPlayers?

Alternatively, the callAllPlayers could be ignored entirely and you could simply do:

videojs.getAllPlayers().forEach(p => p.dispose());

Another alternative approach would be to have getAllPlayers return an array-like object with Player prototype methods mixed in:

const playerCollection = videojs.getAllPlayers();

playerCollection.dispose();

const playerArray = videojs.getAllPlayers().toArray();

[gkatsev]

I'm partial to callAllPlayers but yeah, maybe leave it out for now until we have a real use-case or see people wanting to use it more?

[gkatsev]

LGTM

[gkatsev]

Tested: ☑️