Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace   with \u00a0 fixes #4309 #4825

Merged
merged 1 commit into from
Jan 3, 2018
Merged

replace   with \u00a0 fixes #4309 #4825

merged 1 commit into from
Jan 3, 2018

Conversation

thecotne
Copy link
Contributor

Description

fixes #4309

Specific Changes proposed

replace   with \u00a0 in src/js/control-bar/spacer-controls/custom-control-spacer.js

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@thecotne thecotne mentioned this pull request Dec 19, 2017
Closed
gkatsev
gkatsev approved these changes Jan 3, 2018
View reviewed changes
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gkatsev gkatsev added needs: LGTM Needs one or more additional approvals patch This PR can be added to a patch release. labels Jan 3, 2018
@gkatsev gkatsev added confirmed and removed needs: LGTM Needs one or more additional approvals labels Jan 3, 2018
@gkatsev gkatsev merged commit 98fe49f into videojs:master Jan 3, 2018
@gkatsev gkatsev mentioned this pull request May 9, 2018
Merged
4 tasks
OwenEdwards added a commit to OwenEdwards/video.js that referenced this pull request May 10, 2018
@OwenEdwards
Use \u00a0 insted of   because of videojs#4825.
7606f92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mister-ben mister-ben mister-ben approved these changes

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
confirmed patch This PR can be added to a patch release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not working on XHTML document (caused by  )
3 participants
@thecotne @gkatsev @mister-ben