Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: off text tracks should be set based on current state #4775

Merged
merged 1 commit into from
Dec 4, 2017
Merged

fix: off text tracks should be set based on current state #4775

merged 1 commit into from
Dec 4, 2017

Conversation

brandonocasey
Copy link
Contributor

Description

Prevents a race condition where TextTrackList triggers a change but it is ignored and the OffTextTrackItem is selected alongside the correct track.

Specific Changes proposed

  • Use the handleTracksChange function in the parent class to set the default state of menu items.
  • Do not set OffTextTrackItem to true by default.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@gkatsev gkatsev mentioned this pull request Nov 30, 2017
Closed
@brandonocasey brandonocasey added the needs: LGTM Needs one or more additional approvals label Dec 1, 2017
@gkatsev gkatsev added the patch This PR can be added to a patch release. label Dec 4, 2017
misteroneill
misteroneill approved these changes Dec 4, 2017
View reviewed changes
Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds sensible to me.

@misteroneill misteroneill added confirmed and removed needs: LGTM Needs one or more additional approvals labels Dec 4, 2017
@gkatsev gkatsev merged commit 904989d into master Dec 4, 2017
@gkatsev gkatsev deleted the fix/dont-default-off-to-true branch December 4, 2017 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misteroneill misteroneill misteroneill approved these changes

Assignees
No one assigned
Labels
confirmed patch This PR can be added to a patch release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandonocasey @misteroneill @gkatsev