Fixes TimeUI update on seek #4754
Conversation
| @@ -244,6 +244,8 @@ class SeekBar extends Slider { | |||
| super.handleMouseUp(event); | |||
|
|
|||
| this.player_.scrubbing(false); | |||
| // forces timeui to not use cache | |||
| this.player_.tech_.trigger('timeupdate'); | |||
There was a problem hiding this comment.
is it necessary to trigger on the tech or can we trigger it on the player itself?
Also, we should trigger this event like we do here: https://github.com/videojs/video.js/blob/master/src/js/tech/tech.js#L304-L310
and we should copy over and update the jsdoc as well like there.
There was a problem hiding this comment.
It is necessary to trigger on the tech, I had tried this.player_.trigger, it didn't work. I will update the trigger event.
There was a problem hiding this comment.
Retested with this.player_.trigger and it worked, so updating the trigger on player @gkatsev
There was a problem hiding this comment.
Seems like this improves things, particularly with Flash but doesn't completely fix it with Html5, still sporadically getting the time displays not updating in html5. This is good to be merged anyway since it improves things.
The whole seeking infrastructure in video.js needs to be overhauled, anyway.
|
Also, I updated the jsdoc comment. |
gkatsev
added
needs: LGTM
Description
TimeUpdate ui does not fire on seek when paused.
Specific Changes proposed
By manually triggering a timeupdate we force the ui to not use the cache.
Requirements Checklist