Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default cached src to empty string #4711

Merged
merged 1 commit into from
Nov 1, 2017
Merged

fix: default cached src to empty string #4711

merged 1 commit into from
Nov 1, 2017

Conversation

forbesjo
Copy link
Contributor

@forbesjo forbesjo commented Nov 1, 2017 •
edited
Loading

Description

player.src() returns undefined for a new player.

Specific Changes proposed

Default to '' if there is no source cached.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
  • Reviewed by Two Core Contributors

@forbesjo forbesjo changed the title Default cached src to empty string fix: default cached src to empty string Nov 1, 2017
brandonocasey
brandonocasey approved these changes Nov 1, 2017
View reviewed changes
Copy link
Contributor

@brandonocasey brandonocasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, it is the default in most browsers from what I have seen.

@gkatsev
Copy link
Member

gkatsev commented Nov 1, 2017

@brandonocasey yup, plus, we already do that for currentSrc().

@gkatsev gkatsev merged commit 9acbcd8 into videojs:master Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonocasey brandonocasey brandonocasey approved these changes

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@forbesjo @gkatsev @brandonocasey