Fix playback rate default text #4558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mister-ben
approved these changes
Aug 14, 2017
|
Thanks @rafaelgaspar! |
|
Evaluate new skin video-js-6.2.4 |
atefBB
pushed a commit
to atefBB/video.js
that referenced
this pull request
Aug 16, 2017
Previously, the default text only said `1` now it says `1x` which matches the look after changing the playback rate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug: the playback rate default value was missing the "x".
Specific Changes proposed
Changed the default value from "1", to "1x", to behave the same as when it is after you chose a rate.
Requirements Checklist